Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a retry mechanism when fetching email attachements #2079

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

whabanks
Copy link
Contributor

Summary | Résumé

Adds retry capabilities when fetching email attachments during the send_to_providers process. Uses urllib3 retry functionality.

Copy link
Collaborator

@jzbahrai jzbahrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this! I assumed we had a retry functionality piece already, but turns out we only have those for async celery tasks. would be good to take what you have done and make it a decorator at some point.

@whabanks
Copy link
Contributor Author

whabanks commented Jan 22, 2024

thanks for adding this! I assumed we had a retry functionality piece already, but turns out we only have those for async celery tasks. would be good to take what you have done and make it a decorator at some point.

Love the decorator idea! I've added that to my misc. / downtime tasks list.

@whabanks whabanks merged commit 66d72b5 into main Jan 22, 2024
4 checks passed
@whabanks whabanks deleted the fix/retry-attachement-fetch branch January 22, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants