Rework callback logging

[jimleroyer]

Summary | Résumé

To get the callback logged when not only successful, I moved the callback level log to prior to the call. This removes the response status from that logging but that would get logged anyway via the error when it is logged as an error when an error is raised and caught.

This might not be that useful in production unfortunately because the latter does not have the logging level set to INFO: we wouldn't see this message to help us on support. But that will be useful when we do enable it temporarily or in other environments where we want to get this debugged more easily.

Release Instructions | Instructions pour le déploiement

None.

Necessary steps to perform before and after the deployment of these changes.
For example, emptying the cache on a feature that changes the cache data
structure in Redis could be mentioned.

---

Étapes nécessaires à exécuter avant et après le déploiement des changements
introduits par cette proposition. Par exemple, vider la cache suite à des
changements modifiant une structure de données de la cache pourrait être
mentionné.

Reviewer checklist | Liste de vérification du réviseur

This is a suggested checklist of questions reviewers might ask during their
review | Voici une suggestion de liste de vérification comprenant des questions
que les réviseurs pourraient poser pendant leur examen :

• Is the code maintainable? | Est-ce que le code peut être maintenu?
• Have you tested it? | L’avez-vous testé?
• Are there automated tests? | Y a-t-il des tests automatisés?
• Does this cause automated test coverage to drop? | Est-ce que ça entraîne
  une baisse de la quantité de code couvert par les tests automatisés?
• Does this break existing functionality? | Est-ce que ça brise une
  fonctionnalité existante?
• Does this change the privacy policy? | Est-ce que ça entraîne une
  modification de la politique de confidentialité?
• Does this introduce any security concerns? | Est-ce que ça introduit des
  préoccupations liées à la sécurité?
• Does this significantly alter performance? | Est-ce que ça modifie de
  façon importante la performance?
• What is the risk level of using added dependencies? | Quel est le degré de
  risque d’utiliser des dépendances ajoutées?
• Should any documentation be updated as a result of this? (i.e. README
  setup, etc.) | Faudra-t-il mettre à jour la documentation à la suite de ce
  changement (fichier README, etc.)?

[sastels]

do we want to log the response here if there's an error?

[jimleroyer]

Sorry @sastels for the long delayed response. I am revisiting this. From what I read here, an error seems to raise a RequestException and would then be logged as a warning, hence covering the response status. Most likely the status code would be contained within the e itself I assume. Do you think my read of the code makes sense here?

[sastels]

yeah, that's a good point 💯

[sastels]

LGTM, a good idea. when the code style test is passing!

[jzbahrai]

Can we get this PR merged?