Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification stats discrepancy take 2 - Handling UTC window and DST when fetching notification stats #2064

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Notification stats discrepancy take 2 - Handling UTC window and DST when fetching notification stats #2064

merged 4 commits into from
Dec 18, 2023

Conversation

whabanks
Copy link
Contributor

@whabanks whabanks commented Dec 15, 2023 •
edited
Loading

Summary | Résumé

Implement timezone aware dates that timedelta date math can be used on without the mental load of DST and UTC <-> EST/EDT conversion.

  1. Account for the 4 or 5 hour UTC window when fetching notification counts.
  2. Make it simpler to perform UTC / EST date math in the code.
  3. Gracefully handle EDT/EST daylight savings transitions while still using UTC timezone dates

@whabanks whabanks merged commit f0a7272 into main Dec 18, 2023
4 checks passed
@whabanks whabanks deleted the fix/account-for-utc-dst branch December 18, 2023 15:31
whabanks added a commit that referenced this pull request Dec 18, 2023
@whabanks
Revert "Notification stats discrepancy take 2 - Handling UTC window a…
5445db8 
…nd DST when fetching notification stats (#2064)"

This reverts commit f0a7272.
@whabanks whabanks mentioned this pull request Dec 18, 2023
Merged
whabanks added a commit that referenced this pull request Dec 18, 2023
@whabanks
Revert "Notification stats discrepancy take 2 - Handling UTC window a…
95ae353 
…nd DST when fetching notification stats (#2064)" (#2067)

This reverts commit f0a7272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzbahrai jzbahrai jzbahrai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whabanks @jzbahrai