Smoke Test Loop Script #2038
Closed
Smoke Test Loop Script #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jzbahrai
reviewed
Nov 27, 2023
tests_smoke/smoke_loop.py
Outdated
| init() | ||
|
|
||
|
|
||
| while True: |
There was a problem hiding this comment.
I would put both the init() and this part under the main function, that would be the pythonic way to call this:
def main():
print("Hello World!")
if __name__ == "__main__":
main()
jzbahrai
reviewed
Nov 27, 2023
tests_smoke/smoke_loop.py
Outdated
|
|
||
| result = None | ||
| seconds = None | ||
| startTime = None |
There was a problem hiding this comment.
you don't need to initiatize both startTime and endTime as you are reinitializing underneath
jzbahrai
reviewed
Nov 27, 2023
| global maxRuns | ||
|
|
||
| parser = ArgumentParser() | ||
| parser.add_argument("-m", "--max-runs", dest="maxruns", |
There was a problem hiding this comment.
you could add this documentation in either the Makefile and on top of this script so folks have an example of how to run it
jzbahrai
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Here's a quick script that will run the smoke tests in a loop for a given number of times (or indefinitely)
Test instructions | Instructions pour tester la modification
make smoke-loop -m 2