Update local celery script #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimleroyer
reviewed
Nov 22, 2023
README.md
Outdated
| ``` | ||
| scripts/run_celery_beat.sh | ||
| ``` | ||
| `make run-celery-beat-local` |
There was a problem hiding this comment.
It's great to mention the make target instead. As these are one more level of abstraction, we could even just have a one target named make run-celeries-local, as it doesn't have to be a one to one mapping with the actual scripts but rather intended usage (run celery setup locally).
There was a problem hiding this comment.
hrm, running both the beat and celery workers with one make command? I didn't think that would work, but admittedly didn't try! I shall see!
There was a problem hiding this comment.
oh wow, we can just add "--beat" to the worker script. That was easy.
jimleroyer
previously approved these changes
Nov 22, 2023
sastels
changed the title
|
Clearing approvals since I changed the scripts. |
sastels
dismissed stale reviews from andrewleith and jimleroyer
code changed
jimleroyer
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Update README with local celery infoLocally, have the celery worker also run beat. Update the documentation accordingly.
Test instructions | Instructions pour tester la modification
make run-celery-local