Fix Shellcheck errors by doing as little work as possible #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinRodo
merged commit 8bc84d7
into
feat/fix-and-timeout-celery-scripts
3 checks passed
jimleroyer
added a commit
that referenced
this pull request
Nov 16, 2023
…ing (#2016) * Added timeout to cwagents waiting + shellcheck addition * Setting +x permission on run-shellcheck.sh * Fix Shellcheck errors by doing as little work as possible (#2022) # Summary | Résumé These fixes a bunch of shellcheck errors and ignores a few I didn't test, actually I didn't test any of this, most of the fixes were pretty straightforward ones, there was one I fixed with co-pilot that should be tested and the others I didn't fix I just assumed they worked as is since they were in the existing codebase. - **Fixes**: https://www.shellcheck.net/wiki/SC1091 Couldn't find the file that was being referenced (`environment_test.sh`) in `scripts/run_single_test.sh` so I just the source to /dev/null - **Fixes**: https://www.shellcheck.net/wiki/SC2028 Replaces some echo's where a control character was passed "\n" with a printf so it should work the same and not complain - **Fixes the read -p error**: https://www.shellcheck.net/wiki/SC3045 by asking co-pilot to fix it, I can't guarantee this one will work, **YOU SHOULD TEST THIS FILE: scripts/run_celery_purge.sh** - **Ignores**: https://www.shellcheck.net/wiki/SC2009 I'm assuming it worked and I didn't want to find the pgrep way of doing it, also it's not posix - **Ignores**: https://www.shellcheck.net/wiki/SC2219 I'm assuming it worked and I didn't want to test if the following works ```bash ((wait_time++)) || true ``` - **Fixes**: https://www.shellcheck.net/wiki/SC2105 By removing the break from the case, they don't need it. - **Fixes**: https://www.shellcheck.net/wiki/SC3046 By replacing `source` with `.` - **Fixes**: https://www.shellcheck.net/wiki/SC2068 by wrapping array Expansion with double quotes - **Fixes**: https://www.shellcheck.net/wiki/SC2086 By wrapping the variable in double quotes --------- Co-authored-by: Calvin Rodo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
These fixes a bunch of shellcheck errors and ignores a few I didn't test, actually I didn't test any of this, most of the fixes were pretty straightforward ones, there was one I fixed with co-pilot that should be tested and the others I didn't fix I just assumed they worked as is since they were in the existing codebase.
environment_test.sh) inscripts/run_single_test.shso I just the source to /dev/nullsourcewith.