Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable low retry period for SMS high queue in production #2020

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

jimleroyer
Copy link
Member

Summary | Résumé

Enabling a low retry period for SMS high priority queue in production. This allows for lower retry periods when a retry fail for SMS high priority lane. We had this setting set to true in staging environment for a week. This PR turns it on in production next!

Test instructions | Instructions pour tester la modification

Testing has been done in staging in the past week.

Release Instructions | Instructions pour le déploiement

Move the CloudWatch logs insight query from staging to production to monitor this feature, i.e. how long does the retries for notifications take.

Reviewer checklist | Liste de vérification du réviseur

This is a suggested checklist of questions reviewers might ask during their
review | Voici une suggestion de liste de vérification comprenant des questions
que les réviseurs pourraient poser pendant leur examen :

  • Is the code maintainable? | Est-ce que le code peut être maintenu?
  • Have you tested it? | L’avez-vous testé?
  • Are there automated tests? | Y a-t-il des tests automatisés?
  • Does this cause automated test coverage to drop? | Est-ce que ça entraîne
    une baisse de la quantité de code couvert par les tests automatisés?
  • Does this break existing functionality? | Est-ce que ça brise une
    fonctionnalité existante?
  • Does this change the privacy policy? | Est-ce que ça entraîne une
    modification de la politique de confidentialité?
  • Does this introduce any security concerns? | Est-ce que ça introduit des
    préoccupations liées à la sécurité?
  • Does this significantly alter performance? | Est-ce que ça modifie de
    façon importante la performance?
  • What is the risk level of using added dependencies? | Quel est le degré de
    risque d’utiliser des dépendances ajoutées?
  • Should any documentation be updated as a result of this? (i.e. README
    setup, etc.) | Faudra-t-il mettre à jour la documentation à la suite de ce
    changement (fichier README, etc.)?

@jimleroyer jimleroyer requested review from sastels and ben851 November 14, 2023 21:17
Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it

@jimleroyer jimleroyer merged commit c3df334 into main Nov 14, 2023
4 checks passed
@jimleroyer jimleroyer deleted the feat/enable-sqs-high-retry-prod branch November 14, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants