Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a count of remaining messages to the 80% warning emails #1971

Merged
merged 16 commits into from
Sep 18, 2023

Conversation

whabanks
Copy link
Contributor

@whabanks whabanks commented Sep 6, 2023

Summary | Résumé

This PR adds a count of remaining sms/emails to the daily limit 80% warning emails.

Will merge after this PR to avoid collisions on the migrations:

Test instructions | Instructions pour tester la modification

@whabanks whabanks marked this pull request as draft September 6, 2023 13:43
@whabanks whabanks marked this pull request as ready for review September 14, 2023 14:57
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Testing this locally, and for some reason the SMS email didnt fill in the blanks:
image

Is this working for you? Might be an issue on my end...

@whabanks
Copy link
Contributor Author

whabanks commented Sep 14, 2023

Code looks good. Testing this locally, and for some reason the SMS email didnt fill in the blanks:

Nice catch, there were some spaces after those two placeholders that were encoded incorrectly, probably from copy-pasting from Figma.

Copy link
Collaborator

@jzbahrai jzbahrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-18 at 2 14 13 PM

@jzbahrai jzbahrai merged commit ac442f3 into main Sep 18, 2023
4 checks passed
@jzbahrai jzbahrai deleted the fix/warn-email-add-msgs-left branch September 18, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants