-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MonkeyType to partially automate typing the codebase #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update .gitignore to exclude the monkeytype trace DB
whabanks
changed the title
Add MonkeyType to test dependencies
Use MonkeyType to partially automate typing the codebase
Jul 28, 2023
- poe task updates
jzbahrai
approved these changes
Jul 2, 2024
whabanks
added a commit
that referenced
this pull request
Oct 23, 2024
…)" This reverts commit 3f1a5fc.
whabanks
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This is an experimental PR that adds
monkeytype
and the Poetry plugin Poe the Poet to the project.MonkeyType
Monkeytype collects runtime types of function arguments and return values, and can automatically generate stub files or even add draft type annotations directly to your Python code based on the types collected at runtime.
While it is very useful for automating the process of type annotating Python code bases, it is somewhat cumbersome to work with manually.
Poe the Poet
Enter Poe the Poet, a task runner similar to
make
that provides a simple way to define project tasks directly inpyproject.toml
.Leveraging features like composite tasks and graphs we can create a rich, fully documented ecosystem of project specific tasks.
Since all
poe
tasks are run from within the Poetry virtual env by default, we no longer need to ask ourselves the question "Do I needpoetry run...
in front of this command?", nor would we needpoetry run
in front of nearly every command in ourmakefile
.This PR leverages the plugin to create a basic suite of tasks to simplify using
Monkeytype
. Just runpoe
orpoe --help
to list fully documented tasks:For a deep dive into Poe the Poet check out the wiki page I put together