local smoke tests #1923
Merged
local smoke tests #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben851
reviewed
May 6, 2024
andrewleith
approved these changes
May 6, 2024
| @@ -25,6 +25,7 @@ echo -e "complete -F __start_kubectl k" >> ~/.zshrc | |||
|
|
|||
| # Smoke test | |||
| # requires adding files .env_staging and .env_prod to the root of the project | |||
| echo -e "alias smoke-local='cd /workspace && cp .env_smoke_local tests_smoke/.env && poetry run make smoke-test-local'" >> ~/.zshrc | |||
There was a problem hiding this comment.
There is some nice automation here regarding running the smoke tests in the different environments. Should we add some sort of docs so devs are aware they can do this? Maybe a bit about how/where to store the environment-specific env files?
Maybe its obvious, but it might also be nice to let people know they will need to create a service, some templates, and an API key in order to run them locally.
There was a problem hiding this comment.
yes! good idea - I've added a README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
add smoke testing local api.
.env_smoke_localto send yourself emailssmoke-localalias will send the emails / texts but not verify success (since we don't run the delivery callbacks locally)Makefileto send those locally as well (we typically don't worry about testing them locally unless we're messing around with document-download-api)Test instructions | Instructions pour tester la modification
.env_smoke_localfilemake runandmake run-celery-local-filteredsmoke-local