Skip to content

Commit

Permalink
don't need to set pinpoint active in test
Browse files Browse the repository at this point in the history
  • Loading branch information
sastels committed May 13, 2024
1 parent b6b427b commit 82f0726
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions tests/app/delivery/test_send_to_providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,6 @@

class TestProviderToUse:
def test_should_use_pinpoint_for_sms_by_default(self, restore_provider_details, notify_api):
providers = provider_details_dao.get_provider_details_by_notification_type("sms")
for provider in providers:
if provider.identifier == "pinpoint":
provider.active = True
provider_details_dao.dao_update_provider_details(provider)
with set_config_values(
notify_api,
{
Expand All @@ -69,10 +64,6 @@ def test_should_use_pinpoint_for_sms_by_default(self, restore_provider_details,
assert provider.name == "pinpoint"

def test_should_use_sns_for_sms_if_dedicated_number(self, restore_provider_details, notify_api):
providers = provider_details_dao.get_provider_details_by_notification_type("sms")
for provider in providers:
if provider.identifier == "pinpoint":
provider.active = True
with set_config_values(
notify_api,
{
Expand All @@ -84,10 +75,6 @@ def test_should_use_sns_for_sms_if_dedicated_number(self, restore_provider_detai
assert provider.name == "sns"

def test_should_use_sns_for_sms_if_sending_to_the_US(self, restore_provider_details, notify_api):
providers = provider_details_dao.get_provider_details_by_notification_type("sms")
for provider in providers:
if provider.identifier == "pinpoint":
provider.active = True
with set_config_values(
notify_api,
{
Expand All @@ -100,10 +87,6 @@ def test_should_use_sns_for_sms_if_sending_to_the_US(self, restore_provider_deta

@pytest.mark.parametrize("sc_pool_id, default_pool_id", [(None, "default_pool_id"), ("sc_pool_id", None)])
def test_should_use_sns_if_pinpoint_not_configured(self, restore_provider_details, notify_api, sc_pool_id, default_pool_id):
providers = provider_details_dao.get_provider_details_by_notification_type("sms")
for provider in providers:
if provider.identifier == "pinpoint":
provider.active = True
with set_config_values(
notify_api,
{
Expand Down

0 comments on commit 82f0726

Please sign in to comment.