Add Validation Summary component to edit template forms. #2028
Conversation
🧪 Review environmenthttps://t6qwaap4assgpa5ldswhhs2tmq0kznjv.lambda-url.ca-central-1.on.aws/ |
amazingphilippe
changed the title
amazingphilippe
requested review from
andrewleith,
jzbahrai,
smcmurtry and
whabanks
amazingphilippe
changed the title
| description=_("You can put double brackets around a variable to insert custom content."), | ||
| link_url=gca_url_for('personalisation_guide'), | ||
| link_text=_("Guide: Send messages with custom content"), | ||
| icon="arrow-up-right-from-square" | ||
| ) }} |
There was a problem hiding this comment.
This looks like a code formatting change?
| {{ select( | ||
| form.template_category_id, | ||
| hint=_('Template categories help improve delivery of your messages'), | ||
| option_hints=template_category_hints, option_conditionals=other_category, | ||
| testid="template-categories", | ||
| use_aria_labelledby=false | ||
| ) }} |
There was a problem hiding this comment.
I think it's best to avoid including code formatting changes that are unrelated to the actual change you are trying to make, since it makes the PR bigger than it needs to be. But maybe your editor is just doing this on its own?
There was a problem hiding this comment.
Yes I had to undo an earlier change as the AC for this story was changed a bit. And I couldn't quite get that section back to what it was exactly. And I'm also having some auto-formatting issues as well on html files... Maybe we should see if we can fix that at the container level by adding the correct extensions.
Summary | Résumé
The add-template page has gotten a bit long recently with the introduction of template categories. Suggesting we incorporate the validation summary component to highlight missing fields or errors.
Test instructions | Instructions pour tester la modification
After: We can see all the errors even if not in view.
