Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change/annual limit #2011

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Change/annual limit #2011

merged 3 commits into from
Dec 4, 2024

Conversation

jzbahrai
Copy link
Contributor

@jzbahrai jzbahrai commented Dec 4, 2024

Summary | Résumé

I changed the email_annual_limits and sms_annual_limits in the DB do that it is set to the default of 20million and 100k.
The service settings page is not behind a feature flag anymore - it will always read the result from the DB

Test instructions | Instructions pour tester la modification

  1. You can test this on the review app (the feature flag is on ) - make sure your cache is clear - you will see the above amounts on the service_settings page
  2. You can test it locally with feature flags switched off. you should see all 4 rows have the above data (the two in the sms/ email section and the 2 under platform admin)

Copy link

github-actions bot commented Dec 4, 2024

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and in the review app.

@jzbahrai jzbahrai enabled auto-merge (squash) December 4, 2024 18:39
@jzbahrai jzbahrai merged commit 29f6354 into main Dec 4, 2024
10 of 11 checks passed
@jzbahrai jzbahrai deleted the change/annual-limit branch December 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants