Squash a few routing / UI bugs #1957
Conversation
- The delete button is not longer displayed when there isn't a callback configured - Fixed an issue where the delete confirmation banner wasn't displaying in some circumstances - Fixed a routing issue where deleting a received-text-messages callback was deleting the delivery status callback - Fixed an issue where the Test callback button was not remaining on the same page after clicking
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🧪 Review environmenthttps://jwnyqkrygptikjcji7vkmu2lnq0eqwzh.lambda-url.ca-central-1.on.aws/ |
| return redirect(url_for("main.delivery_status_callback", service_id=service_id)) | ||
|
|
||
| # If the user is just testing their URL, don't send them back to the API Integration page | ||
| if request.form.get("button_pressed") == "test_response_time" and g.callback_response_time >= 1: |
There was a problem hiding this comment.
in this case is the callback saved or not? the flash message doesn't indicate that, whereas if it is <1s, it does say the callback is saved
There was a problem hiding this comment.
Hmm good catch on this case. Right now, if the url or bearer token have changed it will call the update method, then check if the test button was clicked and display the response time.
I think what we want is to check if the test button was clicked first, and put the url/bearer token check + update call in the else. It would be confusing to perform a save and tell them that after they click the test button.
There was a problem hiding this comment.
ok we dont need to change this for now, I guess it is saved? but maybe we need stronger language? your callback should respond <1s for us to count it performant or something like that
Summary | Résumé
This PR fixes a few bugs found during testing on staging for the callbacks changes:
Test instructions | Instructions pour tester la modification