Task/callback UI tests #1955
Open
Task/callback UI tests #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the [validators](https://yozachar.github.io/pyvalidators/stable/) lib to the project - Callback URLs are now checked for validity - Callback URLs are now tested to determine if they are reachable before saving the callback url - Validate that callback urls return 200 responses
- Update error messages - Add logic for catching 5xx and 4xx errors and raise the correct validation error + logging - Fixed ServiceReceiveCallbackMessagesForm validation
- We only want to verify that there's a service running at the specified callback URL. - Additionally we are sending a payload the service won't understand how to response to so a 5xx is likely
- There is now a dedicated delete button to remove a callback configuration instead of needing to empty the form and click save to delete a config - Users will receive a confirmation banner before deletion occurs - Saving, creating, and deleting a callback url now provide the user with a confirmation message that the operation succeeded
- Added a button to the callback config page so users can see the response times of their callback services - Added some translation stubs - The ping to their service takes place as part of the validation
- Add new message content
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
5 tasks
🧪 Review environmenthttps://psdtys77ksgdlozu4kezhatd3i0rxjxr.lambda-url.ca-central-1.on.aws/ |
- Fix issue with text displaying incorrectly on the delete confirmation interstitial
…in' into task/callback-ui-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds UI tests for the callbacks page and support for the new
cache-clearendpoint in API.With the
cache-clearendpoint we can now manage Redis state during Cypress tests.These tests experiment with the use of a utility endpoint in API to assist with cleaning up the DB after a test run.
Test instructions | Instructions pour tester la modification
.envfrom 1Password to get the JWT configs for thecache-clearendpoint calls.