Bump certifi, werkzeug and utils #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzbahrai
approved these changes
Sep 10, 2024
🧪 Review environmenthttps://6ryvawvvhylxtz2hsa4dgr7o2y0bxgik.lambda-url.ca-central-1.on.aws/ |
sastels
reviewed
Sep 10, 2024
|
|
||
| # Pinned dependencies | ||
| rsa = "^4.1" # not directly required, pinned by Snyk to avoid a vulnerability | ||
| certifi = "^2023.7.22" # Pinned for security reasons: https://github.com/cds-snc/notification-admin/security/dependabot/169 | ||
| certifi = "^2024.0.0" # Pinned for security reasons: https://github.com/cds-snc/notification-admin/security/dependabot/169 |
There was a problem hiding this comment.
utils is not forcing certifi 2024.0.0 so I think you can delete this line
There was a problem hiding this comment.
Just doing the bump from the dependency dashboard here since we did bump certifi in utils and poetry was yelling at me 😅
Because notification-admin depends on notifications-utils (52.3.3) @ git+https://github.com/cds-snc/notification-utils.git@bump-patch-deps which depends on certifi (^2024.0.0), certifi is required.
So, because notification-admin depends on certifi (^2023.7.22), version solving failed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Bump certifi, werkzeug and utils version: cds-snc/notification-utils#320
Test instructions | Instructions pour tester la modification