Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin interfact to suspend callback if they exist #1937

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

jzbahrai
Copy link
Contributor

Summary | Résumé

We want to suspend an API callback if they exist.

Test instructions | Instructions pour tester la modification

Use this PR for the API: cds-snc/notification-api#2275

  1. Go to a service
  2. Add a callback
  3. Go to service setting page
  4. If you are admin you should see a toggle at the bottom "Suspend Callback"
  5. Based on the toggle you should see the correct data in your local DB

Test 2:

  1. Go to a service which doesn't have a callback setup
  2. Go to the service setting page - there should be no way for you to Suspend a Callback for that service.

Copy link

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Services with callbacks configured can be suspended and services without callbacks configured do not have the suspension option in the service settings.

@jzbahrai jzbahrai merged commit ae1b884 into main Sep 3, 2024
9 of 10 checks passed
@jzbahrai jzbahrai deleted the task/suspend-callback branch September 3, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants