chore(deps): update dependency pytest to v8 (#375)

* chore(deps): update dependency pytest to v8 * fix: metric tests --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Pat Heard <[email protected]>
cds-snc · Mar 8, 2024 · 0ebf913 · 0ebf913
1 parent 27a9538
commit 0ebf913
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/api/requirements_dev.txt b/api/requirements_dev.txt
@@ -4,7 +4,7 @@ coverage==7.4.3
 flake8==7.0.0
 httpx==0.27.0
 locust==2.23.1
-pytest==7.4.4
+pytest==8.0.2
 requests==2.31.0
 uvicorn==0.27.1
 setuptools>=65.5.1 # not directly required, pinned by Snyk to avoid a vulnerability
diff --git a/api/tests/api_gateway/test_api.py b/api/tests/api_gateway/test_api.py
@@ -423,9 +423,17 @@ def test_metrics(mock_mangum, context_fixture, capsys, metrics):
     mock_mangum.return_value = mock_asgi_handler
     main.handler({"httpMethod": "GET"}, context_fixture)
 
-    log = capsys.readouterr().out.strip()
+    logs = capsys.readouterr().out.strip().split("\n")
 
-    metrics_output = json.loads(log)
+    assert len(logs) == 2
+    metrics_startup = json.loads(logs[0])
+    metrics_output = json.loads(logs[1])
+
+    assert (
+        "ColdStart"
+        in metrics_startup["_aws"]["CloudWatchMetrics"][0]["Metrics"][0]["Name"]
+    )
+    assert metrics_startup["function_name"] == "api"
 
     metric_list = [
         "ListCreated",

diff --git a/api/tests/test_main.py b/api/tests/test_main.py
@@ -1,5 +1,4 @@
 import main
-import json
 from unittest.mock import MagicMock, patch
 
 
@@ -12,14 +11,7 @@ def test_handler_api_gateway_event(mock_mangum, context_fixture, capsys):
     mock_asgi_handler.assert_called_once_with({"httpMethod": "GET"}, context_fixture)
 
     log = capsys.readouterr().out.strip()
-    metrics_output = json.loads(log)
-
     assert "ListManager" in log
-    assert (
-        "ColdStart"
-        in metrics_output["_aws"]["CloudWatchMetrics"][0]["Metrics"][0]["Name"]
-    )
-    assert metrics_output["function_name"] == "api"
 
 
 @patch("main.log")