Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roll back changes to the angular build process #597

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

daine
Copy link
Collaborator

@daine daine commented Jul 29, 2024

Summary | Résumé

This PR fixes the changes applied when PR #586 was merged.

@daine
Copy link
Collaborator Author

daine commented Jul 29, 2024

We need to investigate what is causing the build to fail as the CI didn't catch it before the release went out, and it was passing previously when it was in the React SSR branch.

@daine daine requested review from melaniebmn and ethanWallace July 29, 2024 21:00
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daine daine merged commit 0b62c3a into main Jul 29, 2024
3 checks passed
@daine daine deleted the fix/angular-build-failing branch July 29, 2024 21:41
@daine daine requested a review from melaniebmn July 29, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants