-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add/create @cdssnc/gcds-components-vue package #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - ship it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adds one more update to the README -- I'm aware there might be translation changes as well.
Also, I tested this using this example app and it works pretty well (granted I only really tested the select and header components but it was fun seeing it!)
Co-authored-by: Daine Trinidad <[email protected]>
…/gcds-components into feat/gcds-components-vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hopefully that last commit was the last one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this! We should also get our installation instructions updated once we have this package released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary | Résumé
For easier integration with Vue 3, add the
@cdssnc/gcds-components-vue
package. This provides the GC Design System components within Vue component wrappers.