Merge Astropy Angle support to Master #83
Conversation
Xen0Xys
force-pushed
the
feature/fov-angle-support
branch
from
a7a36d0 to
42c93ce
Compare
| @@ -1,4 +1,4 @@ | |||
| import A from "https://esm.sh/aladin-lite@3.3.3-beta"; | |||
| import A from "https://esm.sh/aladin-lite@3.4.0-beta"; | |||
There was a problem hiding this comment.
You might be able to remove the goToRaDec after initialization with this bump.
There was a problem hiding this comment.
Also, this should be in the changelog and in the readme
There was a problem hiding this comment.
Despite the version change, the removing of gotoRaDec call at the initialization re-introduce the patched bug.
There was a problem hiding this comment.
Too bad, thanks for testing
There was a problem hiding this comment.
In the correspondence table at the end of the README, could you add a line with unreleased || 3.4.0-beta?
There was a problem hiding this comment.
It is because when you instanciate aladin with:
let aladin = Aladin({target: '0 0', cooFrame: 'galactic', ...})as there is no frame given with the target position string, it will take that position as what is given in the cooFrame.
@tboch - Should we consider that behaviour as okaish or target should be always considered as given in ICRS frame ?
There was a problem hiding this comment.
In the correspondence table at the end of the README, could you add a line with
unreleased || 3.4.0-beta?
Done !
No description provided.