Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: be more explicit for errors (widget reduced + widget not ready) #107

Merged
merged 5 commits into from
Sep 13, 2024
Merged

docs: be more explicit for errors (widget reduced + widget not ready) #107

merged 5 commits into from
Sep 13, 2024

Conversation

Xen0Xys
Copy link
Contributor

@Xen0Xys Xen0Xys commented Jul 30, 2024 •
edited
Loading

TO FIX

  • Changing target while the widget is out of sight cause an invalid WCS export

@ManonMarchand
Copy link
Member

Can you rebase on master ? This does not need the hips2fits PR

@ManonMarchand ManonMarchand linked an issue Jul 31, 2024 that may be closed by this pull request
Ask people to wait for widget's loading time #104
Closed
@Xen0Xys Xen0Xys force-pushed the global-improvements branch from 515e366 to 5cdf8a4 Compare August 1, 2024 09:12
@ManonMarchand
Copy link
Member

I think updateWCS and updateFOV should not update the values if _is_reduced is True. Do you agree?

@Xen0Xys
Copy link
Contributor Author

Xen0Xys commented Aug 1, 2024

I think updateWCS and updateFOV should not update the values if _is_reduced is True. Do you agree?

I will check how the FoV react with canvas size, but yes I think that will be better for WCS!

ManonMarchand
ManonMarchand reviewed Aug 1, 2024
View reviewed changes
js/models/event_handler.js
this.updateWCS();
this.update2AxisFoV();
this.model.set("_height", height);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have a height property, so I don't think that this line is really necessary, it's just here in case the user is allow somehow to resise the widget vertically.

@ManonMarchand ManonMarchand linked an issue Aug 1, 2024 that may be closed by this pull request
Listeners functions do not catch their trigger if the widget is not fully loaded #63
Closed
@ManonMarchand ManonMarchand changed the title Merge global improvements to Master docs: be more explicit for errors (widget reduced + widget not ready) Sep 13, 2024
@ManonMarchand ManonMarchand marked this pull request as ready for review September 13, 2024 07:52
@ManonMarchand ManonMarchand merged commit 244e702 into cds-astro:master Sep 13, 2024
4 checks passed
@mperrin mperrin mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonMarchand ManonMarchand ManonMarchand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Xen0Xys @ManonMarchand