Skip to content

Commit

Permalink
edit start server script
Browse files Browse the repository at this point in the history
  • Loading branch information
ManonMarchand committed May 2, 2024
1 parent feb104f commit 1a8d8d4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/js-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
python-version: "3.11"
- name: Install dependencies
run: |
npm install
npm ci
python -m pip install .
python -m pip install jupyterlab
- name: Install Playwright Browser
run: npx playwright install chromium
run: npx playwright install-deps chromium
- name: Run Playwright tests
run: |
npm run start-test-server & npx playwright test
npx playwright test
- uses: actions/upload-artifact@v4
if: always()
with:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"build": "esbuild js/widget.js --minify --format=esm --bundle --outdir=src/ipyaladin/static",
"prepare": "husky install",
"format": "npx prettier . --write && ruff format",
"start-test-server": "python -m jupyter lab --config js/tests/jupyter_server_test_config.py",
"start-test-server": "python -m jupyter lab --config js/ui-tests/jupyter_server_test_config.py",
"python-test": "python -m pytest",
"js-test": "npm run start-test-server & npx playwright test",
"update-snapshots": "npx playwright test --update-snapshots"
Expand Down
4 changes: 2 additions & 2 deletions playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ module.exports = {
...baseConfig,
testDir: "./js/ui-tests",
webServer: {
command: "jlpm start",
command: "npm run start-test-server",
url: "http://localhost:8888/lab",
timeout: 120 * 1000,
reuseExistingServer: !process.env.CI,
},
expect: {
toMatchSnapshot: { maxDiffPixelsRatio: 0.02 }, // allow 2% difference on snapshots
toMatchSnapshot: { maxDiffPixelRatio: 0.02 }, // allow 2% difference on snapshots
},
};

0 comments on commit 1a8d8d4

Please sign in to comment.