Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RADECSYS deprecation fix #164

Merged
merged 2 commits into from
Jun 11, 2024
Merged

RADECSYS deprecation fix #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2cfa4e
:bug: Update Aladin#getViewWCS to have RADESYS instead of RADECSYS th…
Xen0Xys May 29, 2024
2446037
:memo: Update changelog
Xen0Xys May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelogs

## Unreleased

* [fixed] Change `RADECSYS` to `RADESYS` for `Aladin#getViewWCS` to follow fits standard deprecation

## 3.3.3

* [feat] UI: add HiPS basic filter that filters the `hipsList` given
Expand Down Expand Up @@ -353,4 +357,4 @@ New in the API:
### Fin 2013

* ajout catalogue progressif
* ajout on select, objectClicked, objectHovered
* ajout on select, objectClicked, objectHovered
6 changes: 3 additions & 3 deletions src/js/Aladin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2226,7 +2226,7 @@ aladin.on("positionChanged", ({ra, dec}) => {
let cooType2 = "LAT--";

// just in case it would be equatorial
let radecsys;
let radesys;

if (this.getBaseImageLayer().isPlanetaryBody()) {
const body = this.getBaseImageLayer().hipsBody;
Expand All @@ -2240,7 +2240,7 @@ aladin.on("positionChanged", ({ra, dec}) => {
case "J2000d":
cooType1 = "RA---";
cooType2 = "DEC--";
radecsys = "ICRS ";
radesys = "ICRS ";
break;
case "Galactic":
cooType1 = "GLON-";
Expand All @@ -2266,7 +2266,7 @@ aladin.on("positionChanged", ({ra, dec}) => {

// handle the case of equatorial coordinates that need
// the radecsys keyword
if (radecsys == "ICRS ") WCS.RADECSYS = radecsys;
if (radesys == "ICRS ") WCS.RADESYS = radesys;

return WCS;
};
Expand Down
Loading