Disable var camelCaps name check (Squiz.NamingConventions.ValidVariableName.NotCamelCaps) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure what's more important if the psalm check or the cs check 🤷 but I guess I can live without the cs check. |
|
It's rather an issue in the sniff that it cannot be configured.
This one is already excluded in many of our projects. Disabling the whole
psalm rule because of this is not worth it IMO.
…On Fri, Jan 7, 2022, 11:19 Pavel Karfík ***@***.***> wrote:
Not really sure what's more important if the psalm check or the cs check
🤷 but I guess I can live without the cs check.
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQAJJ5HJI7Q35HN2NNI4TUU242ZANCNFSM5LONROBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
p4veI
approved these changes
Jan 13, 2022
fialamarek
approved these changes
Jan 13, 2022
|
I think we should contribute to the sniff - add an option to allow _ names. |
|
@grongor I can create an issue to track it. Though not happening anytime soon (In phpcs there's a lot of work around PHP 8.1, e.g. this is still not reviewed squizlabs/PHP_CodeSniffer#3459). For our v6 this should be excluded (as we do so anyways in projects locally) and we can re-include it later when it does not conflict with SA. |
grongor
approved these changes
Jan 13, 2022
simPod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule conflicts with e.g. psalm's
UnusedClosureParam, see https://psalm.dev/docs/running_psalm/issues/UnusedClosureParam/