chore: update workflows for release and version bump #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealAmazonKendra
force-pushed
the
TheRealAmazonKendra/release-workflow
branch
from
2ecb07d to
8674491
Compare
scanlonp
requested changes
Aug 5, 2024
| const oldVersion = metadata.version; | ||
| const newVersion = semver.inc(oldVersion, 'major'); | ||
| const newVersion = schemasChanged() ? semver.inc(oldVersion, 'major')! : oldVersion; | ||
| const versionFile = path.join(SCHEMA_DIR, 'cloud-assembly.version.json'); |
There was a problem hiding this comment.
Is there a reason to persist this version.json file?
There was a problem hiding this comment.
pre-release testing purposes only. It will be deleted before I do the first release.
scanlonp
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed:
yarn buildwill now automatically update the schema if any changes have been made that will impact it. Not all changes will. This is accomplished by adding the existing commandyarn update-schemainto thepre-compilestep that is run withinyarn build. It is also run in thereleasestep to check for any unintentional changes and will fail the release if uncommitted changes are found (one intentional exception is listed below).bump()will check for any updates to the schema (generated bypre-compile). If there are any, it will update the minimum major version to release by a full major version based off the latest tag in the repository. If there are no changes to the schema, no updates will be made. This is accomplished by settingbump()as the value forminMajorVersion. If there are no changes to the schema, this field will remain undefined but if there are, it will increment the version. This change will not be committed and will be removed once the release has completed, similarly to howunbumpworks inprojenyarn pre-releaserunsupdate-schemaanddefault. Runningdefaultafterupdate-schemaaccomplishes all of the above and re-synthesizes thetasks.jsonfile with the new major version so that thereleasecommand will run on the updated task definition.Any uncommitted changes other than the
minMajorVersionupdate will cause thereleasecommand to fail.