Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first implementation #3

Merged
merged 11 commits into from
Feb 5, 2024
Merged

feat: first implementation #3

merged 11 commits into from
Feb 5, 2024

Conversation

reste85
Copy link
Contributor

@reste85 reste85 commented Jan 30, 2024

First implementation of CDK L2 AVP Constructs

@reste85 reste85 self-assigned this Jan 30, 2024
@cdklabs-automation cdklabs-automation enabled auto-merge (squash) January 30, 2024 15:31
.projenrc.ts Outdated Show resolved Hide resolved
Copy link

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

auto-merge was automatically disabled February 5, 2024 09:48

Merge queue setting changed

.projenrc.ts Outdated Show resolved Hide resolved
mrgrain
mrgrain previously requested changes Feb 5, 2024
Copy link

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the package name to be namespaced.

@mrgrain mrgrain dismissed their stale review February 5, 2024 10:42

Requested changes addressed

@reste85 reste85 added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 7c8f055 Feb 5, 2024
10 checks passed
@reste85 reste85 deleted the feat/first-implementation branch February 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants