fix: avoid behavioural interfaces for Construct Properties #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered as struct by JSII. BREAKING CHANGE: this introduces breaking changes since some property classes of constructs have been changed
andreameroni
approved these changes
Aug 7, 2024
cdklabs-automation
deleted the
fix/removing-behavioural-interfaces-from-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing I notation from props interfaces, in order to be considered as struct by JSII. This solves Python problems of our Constructs that have been addressed thanks to the JSII team in the following issue aws/jsii#4593
BREAKING CHANGE: this introduces breaking changes since some property classes of constructs have been changed