feat(deps): upgrade docker/login-action to v2 (#1000)

To prevent this warning: > Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
cdklabs · Jun 4, 2024 · 14942c1 · 14942c1
1 parent aaae3cd
commit 14942c1
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/src/pipeline.ts b/src/pipeline.ts
@@ -878,7 +878,7 @@ export class GitHubWorkflow extends PipelineBase {
 
     return [
       {
-        uses: 'docker/login-action@v2',
+        uses: 'docker/login-action@v3',
         with: params,
       },
     ];

diff --git a/test/__snapshots__/github.cn.test.ts.snap b/test/__snapshots__/github.cn.test.ts.snap
diff --git a/test/__snapshots__/github.test.ts.snap b/test/__snapshots__/github.test.ts.snap
diff --git a/test/docker.test.ts b/test/docker.test.ts
@@ -28,11 +28,11 @@ describe('correct format for docker credentials:', () => {
     const file = fs.readFileSync(github.workflowPath, 'utf-8');
     const workflow = YAML.parse(file);
 
-    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v2');
+    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v3');
 
     expect(steps.length).toEqual(1);
     expect(steps[0]).toEqual({
-      uses: 'docker/login-action@v2',
+      uses: 'docker/login-action@v3',
       with: {
         registry: '000000000000.dkr.ecr.us-east-1.amazonaws.com',
       },
@@ -44,11 +44,11 @@ describe('correct format for docker credentials:', () => {
     const file = fs.readFileSync(github.workflowPath, 'utf-8');
     const workflow = YAML.parse(file);
 
-    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v2');
+    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v3');
 
     expect(steps.length).toEqual(1);
     expect(steps[0]).toEqual({
-      uses: 'docker/login-action@v2',
+      uses: 'docker/login-action@v3',
       with: {
         username: '${{ secrets.DOCKERHUB_USERNAME }}',
         password: '${{ secrets.DOCKERHUB_TOKEN }}',
@@ -67,11 +67,11 @@ describe('correct format for docker credentials:', () => {
     const file = fs.readFileSync(github.workflowPath, 'utf-8');
     const workflow = YAML.parse(file);
 
-    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v2');
+    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v3');
 
     expect(steps.length).toEqual(1);
     expect(steps[0]).toEqual({
-      uses: 'docker/login-action@v2',
+      uses: 'docker/login-action@v3',
       with: {
         username: '${{ secrets.CUSTOM_USERNAME }}',
         password: '${{ secrets.CUSTOM_PASSWORD }}',
@@ -89,18 +89,18 @@ describe('correct format for docker credentials:', () => {
     const file = fs.readFileSync(github.workflowPath, 'utf-8');
     const workflow = YAML.parse(file);
 
-    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v2');
+    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v3');
 
     expect(steps.length).toEqual(2);
     expect(steps[0]).toEqual({
-      uses: 'docker/login-action@v2',
+      uses: 'docker/login-action@v3',
       with: {
         username: '${{ secrets.DOCKERHUB_USERNAME }}',
         password: '${{ secrets.DOCKERHUB_TOKEN }}',
       },
     });
     expect(steps[1]).toEqual({
-      uses: 'docker/login-action@v2',
+      uses: 'docker/login-action@v3',
       with: {
         registry: '000000000000.dkr.ecr.us-east-1.amazonaws.com',
       },
@@ -146,10 +146,10 @@ describe('correct format for docker credentials:', () => {
     const github = createDockerGithubWorkflow(app, [DockerCredential.ghcr()]);
     const file = fs.readFileSync(github.workflowPath, 'utf-8');
     const workflow = YAML.parse(file);
-    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v2');
+    const steps = findStepByJobAndUses(workflow, 'Assets-DockerAsset1', 'docker/login-action@v3');
 
     expect(steps[0]).toEqual({
-      uses: 'docker/login-action@v2',
+      uses: 'docker/login-action@v3',
       with: {
         registry: 'ghcr.io',
         username: '${{ github.actor }}',