feat: Add support to specify CPU architecture for the to-be-copied image #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongbo-sjtu
changed the title
auto-merge was automatically disabled
November 29, 2024 04:28
Head branch was pushed to by a user without write access
xiongbo-sjtu
changed the title
mrgrain
reviewed
Nov 29, 2024
mrgrain
reviewed
Nov 29, 2024
mrgrain
reviewed
Nov 29, 2024
mrgrain
reviewed
Nov 29, 2024
src/index.ts
Outdated
| /** | ||
| * The image architecture to be copied. | ||
| * | ||
| * @default - "" |
There was a problem hiding this comment.
please explain what this default means in the doc string
mrgrain
reviewed
Nov 29, 2024
| * | ||
| * @default - "" | ||
| */ | ||
| readonly imageArch?: string; |
There was a problem hiding this comment.
I'd probably lean towards this. What do you think?
Suggested change
| readonly imageArch?: string; | |
| readonly architecture?: string; |
There was a problem hiding this comment.
imageArch is intentionally used to avoid any potential confusion with the architecture field referenced by lambda.SingletonFunction in the ECRDeployment class.
Currently, our Dockerfile uses a hard-coded architecture GOARCH=amd64. If we'd like to allow customers to control what's used for the lambda function, we can uplift such a constraint and then expose lambdaArch as a sibling field of imageArch.
Hope that makes sense.
xiongbo-sjtu
force-pushed
the
main
branch
3 times, most recently
from
d439861
to
d5cf620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to add a feature to specify CPU architecture for the to-be-copied image, by triggering the underlying logic here. This will unblock the usage of Graviton instances for Amazon SageMaker and other computing platforms.