feat: Enabling SG passthrough for SingletonFunction #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drduhe
changed the title
douglas1850
approved these changes
Sep 21, 2023
auto-merge was automatically disabled
September 30, 2023 19:13
Head branch was pushed to by a user without write access
drduhe
force-pushed
the
feat/enable-sg-passthrough
branch
from
e2202f5 to
c04e456
Compare
|
@wchaws do you know when I can get this feature on NPM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # #348
Will allow users to supply their own security groups to the ECRDeployment construct to be used by the SingletonFunction. This change was made locally to the source and tested by passing in a custom security group for deployment into a customer account.