feat: use sdkv3 #47
Merged
feat: use sdkv3 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comcalvi
requested changes
Aug 28, 2024
| process.env.AWS_SDK_JS_SUPPRESS_MAINTENANCE_MODE_MESSAGE = '1'; | ||
| this.config = { | ||
| clientConfig, | ||
| credentials: fromNodeProviderChain({ |
There was a problem hiding this comment.
Nice, this is a big improvement over random env vars
|
|
||
| return upload.done(); | ||
| } catch (e) { | ||
| // TODO: add something more useful here |
There was a problem hiding this comment.
I'll add something here before I remove the release candidate tag. I need to actually test the failure modes in the CLI to figure out what will be useful information here.
| return true; | ||
| } catch (e: any) { | ||
| if (e.code !== 'ImageNotFoundException') { | ||
| if (e.name !== 'ImageNotFoundException') { |
There was a problem hiding this comment.
why the change from code to name?
There was a problem hiding this comment.
SDK v3 updated the error class as such that code is no longer a field and name is the replacement for it. No idea why they did that ¯_(ツ)_/¯
lib/private/handlers/files.ts
Outdated
| @@ -130,7 +131,7 @@ export class FileAssetHandler implements IAssetHandler { | |||
| paramsEncryption | |||
| ); | |||
|
|
|||
| await s3.upload(params).promise(); | |||
| await this.host.aws.upload(params, {}); | |||
There was a problem hiding this comment.
can we make the second parameter optional?
Co-authored-by: Calvin Combs <[email protected]>
Co-authored-by: Calvin Combs <[email protected]>
comcalvi
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates usage of the sdk to sdkv3 and begins publishing it on a new major version. For the moment we will publish these as release candidates until we are sure of stability.