Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct the MicrosoftSharepointOnline AppFlow implementation #22

Merged
merged 6 commits into from
Oct 27, 2023
Merged

fix: correct the MicrosoftSharepointOnline AppFlow implementation #22

merged 6 commits into from
Oct 27, 2023

Conversation

rpawlaszek
Copy link
Contributor

This PR fixes #21 by correcting the ConnectorLabel (i.e. setting its value to MicrosoftSharePointOnline

Additionally:

  • a dedicated integration test has been created for MS Sharepoint Online constructs
  • a correct approach to specifying the MS Sharepoint Online source object has been implemented

@rpawlaszek rpawlaszek requested review from kozub and psrebniak October 26, 2023 21:59
psrebniak
psrebniak approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@psrebniak psrebniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mergify mergify bot merged commit 975e553 into main Oct 27, 2023
12 checks passed
@mergify mergify bot deleted the rpawlasz/21-microsoftsharepointonline branch October 27, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrebniak psrebniak psrebniak approved these changes

@kozub kozub Awaiting requested review from kozub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect ConnectorLabel for the MS SharePoint Online connector profile
2 participants
@rpawlaszek @psrebniak