fix: update aws-cdk-lib dependency and GitHubRepo.repository logic (

#1776) * Allow versions of aws-cdk-lib greater than * Fix repo parsing logic --------- Co-authored-by: Leonardo Gama <[email protected]>
cdklabs · Nov 21, 2024 · d380c26 · d380c26
1 parent 9a22548
commit d380c26
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 24 deletions.
diff --git a/lib/__tests__/auto-build.test.ts b/lib/__tests__/auto-build.test.ts
@@ -14,7 +14,7 @@ beforeEach(() => {
 test('webhooks are enabled by default', () => {
   new AutoBuild(stack, 'AutoBuild', {
     repo: new GitHubRepo({
-      repository: 'some-repo',
+      repository: 'some-owner/some-repo',
       tokenSecretArn: 'arn:aws:secretsmanager:someregion:someaccount:secret:sometoken',
     }),
   });
@@ -38,7 +38,7 @@ test('webhooks are enabled by default', () => {
 test('webhooks for a single branch', () => {
   new AutoBuild(stack, 'AutoBuild', {
     repo: new GitHubRepo({
-      repository: 'some-repo',
+      repository: 'some-owner/some-repo',
       tokenSecretArn: 'arn:aws:secretsmanager:someregion:someaccount:secret:sometoken',
     }),
     branch: 'banana',
@@ -77,7 +77,7 @@ test('webhooks for a single branch', () => {
 test('webhooks for multiple branches', () => {
   new AutoBuild(stack, 'AutoBuild', {
     repo: new GitHubRepo({
-      repository: 'some-repo',
+      repository: 'some-owner/some-repo',
       tokenSecretArn: 'arn:aws:secretsmanager:someregion:someaccount:secret:sometoken',
     }),
     branches: ['banana', 'grapefruit'],
@@ -116,7 +116,7 @@ test('webhooks for multiple branches', () => {
 test('can disable webhooks', () => {
   new AutoBuild(stack, 'AutoBuild', {
     repo: new GitHubRepo({
-      repository: 'some-repo',
+      repository: 'some-owner/some-repo',
       tokenSecretArn: 'arn:aws:secretsmanager:someregion:someaccount:secret:sometoken',
     }),
     webhook: false,
@@ -133,7 +133,7 @@ test('can disable webhooks', () => {
 test('can enable artifacts', () => {
   new AutoBuild(stack, 'AutoBuild', {
     repo: new GitHubRepo({
-      repository: 'some-repo',
+      repository: 'some-owner/some-repo',
       tokenSecretArn: 'arn:aws:secretsmanager:someregion:someaccount:secret:sometoken',
     }),
     artifacts: Artifacts.s3({

diff --git a/lib/repo.ts b/lib/repo.ts
@@ -106,6 +106,9 @@ export class GitHubRepo implements IRepo {
 
   constructor(props: GitHubRepoProps) {
     const repository = props.repository;
+    if (repository.indexOf('/') == -1) {
+      throw new Error('Repository must be of the form "account/repo"');
+    }
     const [owner, repo] = repository.split('/');
 
     this.owner = owner;

diff --git a/package.json b/package.json
diff --git a/yarn.lock b/yarn.lock