Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "switch to v4; fix schema org URL" #1270

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Dec 11, 2024

This reverts commit 4ef66b8.

See #1261 (comment) for details and rationale.

@elray1
Copy link
Collaborator

elray1 commented Dec 11, 2024

I note that the validations themselves passed:
image

The check failure is due to a separate issue in a following step about commenting on the PR.

That is to say, I think it would be fine to merge this PR. @zkamvar do you agree?

@zkamvar
Copy link
Contributor Author

zkamvar commented Dec 11, 2024

agreed.

@elray1
Copy link
Collaborator

elray1 commented Dec 11, 2024

@Annabella-Hines @smathis14 @rborchering I'm going to defer to you all to merge this in since you are the owners of the repo. But just to be clear, the idea of this PR is to roll back to version 3.0.1 of the hubverse schema rather than v4. Once this PR has been merged in, you should be able to re-run validations on the FluSight-baseline submission for this week (e.g. by closing and re-opening that PR, #1261) and get a passing result.

We will work on sorting out the validations issue that came up, and we can try again with the v4 upgrade later. Sorry for the inconvenience here!

@Annabella-Hines Annabella-Hines merged commit 54b5753 into cdcepi:main Dec 11, 2024
1 check failed
@Annabella-Hines
Copy link
Collaborator

Thank you both for your help on this, we definitely appreciate the quick response!

@zkamvar
Copy link
Contributor Author

zkamvar commented Dec 12, 2024

We have officially released the fix and it should be generally available within the hour: https://github.com/hubverse-org/hubValidations/releases/tag/v0.10.0

Sorry again for the mixup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants