Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🍒][CDAP-21047] removing log4j classes from application jar due to conflict with dataproc 2.2 #15669

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[🍒][CDAP-21047] removing log4j classes from application jar due to conflict with dataproc 2.2 #15669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cdap-common/src/main/java/io/cdap/cdap/common/twill/HadoopClassExcluder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import java.net.URL;
import org.apache.twill.api.ClassAcceptor;

/**

Check warning on line 22 in cdap-common/src/main/java/io/cdap/cdap/common/twill/HadoopClassExcluder.java

View workflow job for this annotation

GitHub Actions / Checkstyle

com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck 

First sentence of Javadoc is missing an ending period.
* Exclude hadoop classes
*/
public class HadoopClassExcluder extends ClassAcceptor {
Expand All @@ -39,6 +39,14 @@
return false;
}
}

// We don't use the log4j-api library from org.apache.logging.
// However, when ran in distributed mode which contains it,
// causes conflicts with it if we include it.
if (className.startsWith("org.apache.logging.log4j")) {
return false;
}

// We don't use the snappy library from org.iq80. We use the one from org.xerial.snappy.
// This is an optional dependency from org.iq80.leveldb, hence it is not included in CDAP
// However, the hive-exec contains it, which can mess up other dependency if we include it.
Expand Down