[CDAP-20957] Add scopes support to Remote Authenticator #15542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
force-pushed
the
PLUGIN-1746
branch
from
25d796c to
99f3702
Compare
itsankit-google
changed the title
itsankit-google
force-pushed
the
PLUGIN-1746
branch
2 times, most recently
from
7018863 to
9e61ca3
Compare
dli357
reviewed
Feb 9, 2024
cdap-common/src/main/java/io/cdap/cdap/common/internal/remote/GceRemoteAuthenticator.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/worker/sidecar/GcpMetadataHttpHandlerInternal.java
Outdated
Show resolved
Hide resolved
itsankit-google
force-pushed
the
PLUGIN-1746
branch
from
9e61ca3 to
7b0d4a9
Compare
itsankit-google
force-pushed
the
PLUGIN-1746
branch
2 times, most recently
from
a8a9903 to
9d112e4
Compare
dli357
approved these changes
Feb 12, 2024
itsankit-google
force-pushed
the
PLUGIN-1746
branch
from
9d112e4 to
6af7eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CDAP-20957
context: We implemented fake metadata server in
CDAP 6.10.0which falls back to actual metadata server when namespace service account is not configured. In that case, we do not accept scopes which is an important property when fetching token for APIs which are not included in cloud platform scope likedrive.googleapis.com, etc.Before Fix:
After Fix:
