Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-20815] Fix pipeline description on pipeline upgrade #15423

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

vsethi09
Copy link
Contributor

@vsethi09 vsethi09 commented Nov 10, 2023

Issue

CDAP-20815 Pipeline’s description is replaced with “Data Pipeline Application” when invoking /upgrade REST API

Repro Steps

To reproduce the issue:

  • Deploy a pipeline in an instance with some description.
  • Either follow the pipeline upgrade process or call the POST /upgrade method for the pipeline.
  • Once upgrade finishes, check pipeline description. It’s been set to “Data Pipeline Application”

This can be reproed in 6.6.0 - 6.9.x. May also be reproduced in versions < 6.6.0.

Root Cause

On pipeline upgrade the description of the pipeline is preserved and set to null. The null description is defaulted to Data Pipeline Application (code)

Solution

Preserve the pipeline description during upgrades for both Batch and Stream pipelines.

Verification

  • Verified using sandbox instance.
  • Created a pipeline with some description.
  • Upgraded the pipeline.
  • Verified that the description is the same and not changed to the default one.

@vsethi09 vsethi09 added the build Triggers github actions build label Nov 10, 2023
@vsethi09 vsethi09 marked this pull request as ready for review November 10, 2023 12:29
@vsethi09 vsethi09 force-pushed the bugfix/CDAP-20815-pipeline-desc-fix branch from 77b7100 to bef34b8 Compare November 20, 2023 17:51
@vsethi09 vsethi09 changed the title [WIP][CDAP-20815] Fix pipeline description on pipeline upgrade [CDAP-20815] Fix pipeline description on pipeline upgrade Nov 20, 2023
@vsethi09 vsethi09 merged commit df54ea3 into develop Nov 21, 2023
11 checks passed
@vsethi09 vsethi09 deleted the bugfix/CDAP-20815-pipeline-desc-fix branch November 21, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants