Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-20795] remove identity from namespace wi request body #15403

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

itsankit-google
Copy link
Member

@itsankit-google itsankit-google commented Nov 2, 2023

Since the GcpWorkloadIdentityHttpHandler has access to the namespaceMeta we don't need the namespace identity in the request body.

Updated requests:

Create/Update Identity

PUT v3/namespaces/{namespace-id}/credentials/workloadIdentity

body: {"serviceAccount":"<GSA_EMAIL>"}

image

Validate Identity

POST v3/namespaces/<namespace>/credentials/workloadIdentity/validate

body: {"serviceAccount":"<GSA_EMAIL>"}

image

@itsankit-google itsankit-google added build Triggers github actions build namespaced_service_accounts Label for tracking namespaced service accounts feature labels Nov 2, 2023
@itsankit-google itsankit-google merged commit 6eb7ee0 into develop Nov 2, 2023
10 checks passed
@itsankit-google itsankit-google deleted the CDAP-20795 branch November 2, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.10 build Triggers github actions build namespaced_service_accounts Label for tracking namespaced service accounts feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants