[CDAP-20824] Emit zero for flow-control launching metric if there is no inflight launching pipeline when appfabric starts #15357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masoud-io
force-pushed
the
bugfixes/cdap-20824
branch
from
61ca52b to
49c7256
Compare
albertshau
approved these changes
Oct 12, 2023
| @@ -188,7 +188,7 @@ public void removeRequest(ProgramRunId programRunId, boolean emitRunningChange) | |||
| } | |||
| } | |||
|
|
|||
| private void emitMetrics(String metricName, long value) { | |||
| public void emitMetrics(String metricName, long value) { | |||
There was a problem hiding this comment.
nit: I think it would be a little better to add a public emitLaunchingMetric(long value) method and keep this one private. That way the metric name stays a detail of this class instead of in both.
There was a problem hiding this comment.
Great suggestion. Done.
masoud-io
force-pushed
the
bugfixes/cdap-20824
branch
from
49c7256 to
8ce0edc
Compare
…aunching pipeline when appfabric starts
masoud-io
force-pushed
the
bugfixes/cdap-20824
branch
from
8ce0edc to
f9e0935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.