Skip to content

Commit

Permalink
Merge pull request #15683 from cdapio/CDAP-21053
Browse files Browse the repository at this point in the history
[CDAP-21053] Adding logic to delete lineage data.
  • Loading branch information
ritwiksahani authored Aug 23, 2024
2 parents 301e89e + e23102f commit f5f8cb5
Show file tree
Hide file tree
Showing 18 changed files with 608 additions and 128 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class AppFabricServer extends AbstractIdleService {
private final ProgramNotificationSubscriberService programNotificationSubscriberService;
private final ProgramStopSubscriberService programStopSubscriberService;
private final RunRecordCorrectorService runRecordCorrectorService;
private final RunRecordTimeToLiveService runRecordTimeToLiveService;
private final RunDataTimeToLiveService runDataTimeToLiveService;
private final ProgramRunStatusMonitorService programRunStatusMonitorService;
private final RunRecordMonitorService runRecordCounterService;
private final CoreSchedulerService coreSchedulerService;
Expand Down Expand Up @@ -131,7 +131,7 @@ public AppFabricServer(CConfiguration cConf, SConfiguration sConf,
TransactionRunner transactionRunner,
RunRecordMonitorService runRecordCounterService,
CommonNettyHttpServiceFactory commonNettyHttpServiceFactory,
RunRecordTimeToLiveService runRecordTimeToLiveService,
RunDataTimeToLiveService runDataTimeToLiveService,
SourceControlOperationRunner sourceControlOperationRunner,
RepositoryCleanupService repositoryCleanupService,
OperationNotificationSubscriberService operationNotificationSubscriberService) {
Expand All @@ -158,7 +158,7 @@ public AppFabricServer(CConfiguration cConf, SConfiguration sConf,
this.systemAppManagementService = systemAppManagementService;
this.transactionRunner = transactionRunner;
this.runRecordCounterService = runRecordCounterService;
this.runRecordTimeToLiveService = runRecordTimeToLiveService;
this.runDataTimeToLiveService = runDataTimeToLiveService;
this.commonNettyHttpServiceFactory = commonNettyHttpServiceFactory;
this.sourceControlOperationRunner = sourceControlOperationRunner;
this.repositoryCleanupService = repositoryCleanupService;
Expand Down Expand Up @@ -191,7 +191,7 @@ protected void startUp() throws Exception {
coreSchedulerService.start(),
credentialProviderService.start(),
runRecordCounterService.start(),
runRecordTimeToLiveService.start(),
runDataTimeToLiveService.start(),
sourceControlOperationRunner.start(),
repositoryCleanupService.start(),
operationNotificationSubscriberService.start()
Expand Down Expand Up @@ -250,7 +250,7 @@ protected void shutDown() throws Exception {
programRunStatusMonitorService.stopAndWait();
provisioningService.stopAndWait();
runRecordCounterService.stopAndWait();
runRecordTimeToLiveService.stopAndWait();
runDataTimeToLiveService.stopAndWait();
sourceControlOperationRunner.stopAndWait();
repositoryCleanupService.stopAndWait();
credentialProviderService.stopAndWait();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
/*
* Copyright © 2023 Cask Data, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/

package io.cdap.cdap.internal.app.services;

import com.google.common.collect.ImmutableList;
import com.google.common.util.concurrent.AbstractIdleService;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import com.google.inject.Inject;
import io.cdap.cdap.common.conf.CConfiguration;
import io.cdap.cdap.common.conf.Constants;
import io.cdap.cdap.data2.metadata.lineage.LineageTable;
import io.cdap.cdap.data2.metadata.lineage.field.FieldLineageTable;
import io.cdap.cdap.internal.app.store.AppMetadataStore;
import io.cdap.cdap.spi.data.transaction.TransactionException;
import io.cdap.cdap.spi.data.transaction.TransactionRunner;
import java.time.Clock;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* Service which periodically scans the database tables for records which should be deleted per the
* global time to live value.
*
* <p>Does not run if no TTL is configured or a TTL of 0 is specified.
* <p>
* This service would invoke other TTL based clean up services which implement the interface
* {@link CleanupService}. Those services would be called in sequence.
* </p>
*/
public final class RunDataTimeToLiveService extends AbstractIdleService {

private static final Logger LOG = LoggerFactory.getLogger(RunDataTimeToLiveService.class);

private final TransactionRunner transactionRunner;
private final boolean isEnabled;
private final Duration ttlMaxAge;
private final Duration checkFrequency;
private final Duration initialDelay;
private final Clock clock;

private ScheduledExecutorService service;
private List<CleanupService> cleanupServiceList;

@Inject
RunDataTimeToLiveService(CConfiguration cConf, TransactionRunner transactionRunner) {
// Negative TTLs do not make sense, treat as 0.
this.ttlMaxAge =
Duration.ofDays(Math.max(cConf.getInt(Constants.AppFabric.RUN_DATA_CLEANUP_TTL_DAYS), 0));
this.isEnabled = !this.ttlMaxAge.isZero();
// Delay should be at least 1 hour to ensure it isn't infinitely running.
this.checkFrequency =
Duration.ofHours(
Math.max(cConf.getInt(Constants.AppFabric.RUN_DATA_CLEANUP_TTL_FREQUENCY_HOURS), 1));
// Negative delays do not make sense, treat as 0.
this.initialDelay =
Duration.ofMinutes(
Math.max(
cConf.getInt(Constants.AppFabric.RUN_DATA_CLEANUP_TTL_INITIAL_DELAY_MINUTES), 0));

this.transactionRunner = transactionRunner;
this.clock = Clock.systemUTC();
this.cleanupServiceList = ImmutableList.of(
new RunRecordsCleanupService(),
new LineageCleanupService(),
new FieldLineageCleanupService());
}

@Override
protected void startUp() {
if (!isEnabled) {
LOG.info("No TTL configured, skipping starting RunDataTimeToLiveService");
return;
}

service =
Executors.newSingleThreadScheduledExecutor(
new ThreadFactoryBuilder().setNameFormat("Records TTL janitor").build());

service.scheduleAtFixedRate(
() -> doCleanup(),
initialDelay.getSeconds(),
checkFrequency.getSeconds(),
TimeUnit.SECONDS);
}

@Override
protected void shutDown() {
if (!isEnabled) {
// no-op because no services were started.
return;
}
LOG.info("Stopping RunDataTimeToLiveService");

service.shutdownNow();
}

private void doCleanup() {
Instant endDate = Instant.now(clock).minus(ttlMaxAge);
// Perform cleanup together for all services with a fixed end time. This is currently a
// sequential call and may be executed parallelly in future if required.
this.cleanupServiceList.forEach(service -> {
long startTime = System.currentTimeMillis();
service.doCleanup(endDate);
double timeTaken = (System.currentTimeMillis() - startTime) / 1000.0;
LOG.info("{} cleanup completed in {} seconds", service.getClass().getName(), timeTaken);
});
}

private interface CleanupService {

void doCleanup(Instant endDate);
}

private class RunRecordsCleanupService implements CleanupService {

@Override
public void doCleanup(Instant endDate) {
LOG.info("Doing scheduled cleanup, deleting all run records before {}", endDate);

try {
transactionRunner.run(
context -> {
AppMetadataStore appMetadataStore = AppMetadataStore.create(context);

appMetadataStore.deleteCompletedRunsStartedBefore(endDate);
});
} catch (TransactionException e) {
LOG.error("Failed to clean up old run records", e);
}
}
}

private class LineageCleanupService implements CleanupService {

@Override
public void doCleanup(Instant endDate) {
LOG.info("Doing scheduled cleanup, deleting all run lineage records before {}", endDate);

try {
transactionRunner.run(
context -> {
LineageTable lineageTable = LineageTable.create(context);

lineageTable.deleteCompletedLineageRecordsStartedBefore(endDate);
});
} catch (TransactionException e) {
LOG.error("Failed to clean up old lineage records", e);
}
}
}


private class FieldLineageCleanupService implements CleanupService {

@Override
public void doCleanup(Instant endDate) {
LOG.info("Doing scheduled cleanup, deleting all field lineage records before {}", endDate);

try {
transactionRunner.run(
context -> {
FieldLineageTable fieldLineageTable = FieldLineageTable.create(context);

fieldLineageTable.deleteFieldRecordsBefore(endDate);
});
} catch (TransactionException e) {
LOG.error("Failed to clean up old field lineage records", e);
}
}
}
}

This file was deleted.

Loading

0 comments on commit f5f8cb5

Please sign in to comment.