Skip to content

Commit

Permalink
Merge pull request #15382 from cdapio/features/cdap-20845-p4
Browse files Browse the repository at this point in the history
[CDAP-20845] Deprecate transactional feature in cdap-messaging-spi - Part 4
  • Loading branch information
masoud-io authored Oct 27, 2023
2 parents a784b2d + 7917dfa commit 766a67e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ RollbackDetail publish(StoreRequest request)
* @throws IOException if failed to store messages
* @throws ServiceUnavailableException if the messaging service is not available
*/
@Deprecated
void storePayload(StoreRequest request)
throws TopicNotFoundException, IOException, UnauthorizedException;

Expand All @@ -132,6 +133,7 @@ void storePayload(StoreRequest request)
* @throws IOException if failed to rollback changes
* @throws ServiceUnavailableException if the messaging service is not available
*/
@Deprecated
void rollback(TopicId topicId, RollbackDetail rollbackDetail)
throws TopicNotFoundException, IOException, UnauthorizedException;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
/**
* This interface represents information needed to rollback message published transactionally.
*/
@Deprecated
public interface RollbackDetail {

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,17 @@ public interface StoreRequest extends Iterable<byte[]> {
TopicId getTopicId();

/** Returns {@code true} if the message should be published transactionally. */
@Deprecated
boolean isTransactional();

/**
* Returns the transaction write pointer if the message is going to be published transactionally,
* that is when {@link #isTransactional()} returns {@code true}.
*/
@Deprecated
long getTransactionWritePointer();

/** Returns {@code true} if there is payload in this request. */
@Deprecated
boolean hasPayload();
}

0 comments on commit 766a67e

Please sign in to comment.