Merge pull request #294 from cdapio/log_exceptions

Log stack trace when NamingException is thrown
cdapio · Feb 16, 2024 · ef3fbd9 · ef3fbd9
2 parents 6d89359 + 570113e
commit ef3fbd9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/.../src/main/java/io/cdap/cdap/security/authorization/ldap/role/searcher/LDAPClientImpl.java b/.../src/main/java/io/cdap/cdap/security/authorization/ldap/role/searcher/LDAPClientImpl.java
@@ -46,7 +46,7 @@ public DirContext getConnection() throws NamingException {
             try {
                 return new InitialDirContext(properties);
             } catch (NamingException e) {
-                LOG.warn("Failed connect to '{}' on attempt '{}'", config.getUrl(), i);
+                LOG.warn("Failed connect to '{}' on attempt '{}'", config.getUrl(), i, e);
 
                 // Throw error if maximum of attempts is reached
                 if (i == LDAPConstants.MAX_CONNECTION_RETRIES) {

diff --git a/...le/src/main/java/io/cdap/cdap/security/authorization/ldap/role/searcher/LDAPSearcher.java b/...le/src/main/java/io/cdap/cdap/security/authorization/ldap/role/searcher/LDAPSearcher.java
@@ -83,24 +83,14 @@ public Set<String> searchGroups(String username) {
           context.close();
         }
       } catch (NamingException e) {
-        Throwable cause = e.getCause();
-
-        // Getting informative error message
-        String exceptionMessage;
-        if (cause == null) {
-          exceptionMessage = e.getMessage();
-        } else {
-          exceptionMessage = cause.getMessage();
-        }
-
-        String errorMsg = String.format("Failed to find groups for user '%s': %s", username, exceptionMessage);
+        String errorMsg = String.format("Failed to find groups for user '%s'", username);
 
         // Throw error if maximum of attempts is reached
         if (i == LDAPConstants.MAX_SEARCH_RETRIES) {
           throw new RuntimeException(errorMsg, e);
         }
 
-        LOG.warn(errorMsg);
+        LOG.warn(errorMsg, e);
         sleep(i * LDAPConstants.DEFAULT_RETRY_INTERVAL);
       }
     }