Refactored common sentry setup #30
Merged
+25
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of our applications are not actually connected to sentry, for example: https://github.com/ccnmtl/footprints/blob/master/footprints/settings_production.py#L5 The ctlsettings common() method requires the `sentry_dsn` param to be set, which isn't in this case, and isn't available until local_settings is imported. Some applications are set up for sentry where they init sentry within the application: https://github.com/ccnmtl/mediathread/blob/master/mediathread/settings_production.py#L49 With this update to ctlsettings, applications can call the common code to initialize sentry using a pattern like this: ``` from ctlsettings.production import init_sentry """ after local_settings import """ if hasattr(settings, 'SENTRY_DSN'): init_sentry(SENTRY_DSN) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our applications are not actually connected to sentry, for example:
https://github.com/ccnmtl/footprints/blob/master/footprints/settings_production.py#L5
The ctlsettings common() method requires the
sentry_dsnparam to be set, which isn't in this case, and isn't available until local_settings is imported.Some applications are set up for sentry where they init sentry within the application: https://github.com/ccnmtl/mediathread/blob/master/mediathread/settings_production.py#L49
With this update to ctlsettings, applications can call the common code to initialize sentry using a pattern like this: