Add missing ordering relationships

[theosotr]

This pull request adds missing ordering relationships between Package['syslog-ng'] and its associated files.

Without those missing ordering relationships, the code is unstable because configuration should always be applied after installation of the package.

[faxm0dem]

thanks for this patch, but I want to minimize package handling anyway : there is the syslog_ng module for that. I will probably require that module at some point. Your patch fails when disabling package management also.

[smortex]

Dang, I did not see you pushed a fix! That was a while ago, but the change may still make sense. I rebased your fix on top of the master branch so that CI is run against it (we added CI to the project 😉), to ensure it does not break something (CentOS failures are expected and can be ignored. #49 will silence them).

It seems to be fine, so LGTM!

What do you think @faxm0dem ?

[faxm0dem]

My initial remark can be rewritten this way : should we require the package, or the puppet module ?

[smortex]

I like it when packages and services are isolated in a dedicated class (e.g. syslog_ng::package, syslog_ng::service) which allow to have dependencies and notifications the easy way:

Class['syslog_ng::package'] -> Foo['bar'] ~> Class['syslog_ng::service']

But the syslog_ng module currently manage package and service in the main manifest (init.pp), so that would require a new backwards-incomptable change of the module to introduce a backwards-incomptable change in this module. As far as I am concerned, I don't mind doing major version bumps, but some people don't like it. Do you want me to work on this?

[faxm0dem]

I like the idea very much, but le'ts post-pone this and add it to a like-to-have todo list