Rely on Hiera to get the config directory

This directory is operating-system dependant.

data/default.yaml

@@ -9,4 +9,4 @@ patterndb::use_hiera: false
 patterndb::_manage_top_dirs: true
 patterndb::test_before_deploy: &test_before_deploy true
 patterndb::parser::test_before_deploy: *test_before_deploy
-
+patterndb::config_dir: /etc/syslog-ng/patterndb.d

data/osfamily/FreeBSD.yaml

@@ -0,0 +1,2 @@
+---
+patterndb::config_dir: /usr/local/etc/patterndb.d

manifests/init.pp

@@ -1,6 +1,7 @@
 #
 class patterndb (
   String[1] $package_name,
+  Stdlib::Absolutepath $config_dir,
   String[1] $base_dir = '/',
   String[1] $temp_dir = "${base_dir}/tmp/syslog-ng",
   Boolean $manage_package = true,
@@ -35,8 +36,7 @@
       recurse => true
     }
   )
-  $pdb_dir = "${base_dir}/etc/syslog-ng/patterndb.d"
-  file { $pdb_dir:
+  file { $config_dir:
     ensure  => directory,
     purge   => true,
     force   => true,

manifests/parser.pp

@@ -15,7 +15,7 @@
     $tmp = join($_modules,' --module=')
     $modules = "--module=${tmp}"
   }
-  ensure_resource('file', "${patterndb::pdb_dir}/${name}", {
+  ensure_resource('file', "${patterndb::config_dir}/${name}", {
       'ensure'  => 'directory',
       'purge'   => true,
       'force'   => true,
@@ -29,7 +29,7 @@
       'path'   => "${patterndb::base_dir}/var/lib/syslog-ng/patterndb/${name}.xml"
   })
   exec { "patterndb::merge::${name}":
-    command     => "pdbtool merge -r --glob \\*.pdb -D ${patterndb::pdb_dir}/${name} -p ${patterndb::temp_dir}/patterndb/${name}.xml",
+    command     => "pdbtool merge -r --glob \\*.pdb -D ${patterndb::config_dir}/${name} -p ${patterndb::temp_dir}/patterndb/${name}.xml",
     path        => $facts['path'],
     logoutput   => true,
     refreshonly => true,

manifests/raw/ruleset.pp

@@ -20,7 +20,7 @@
   }
 
   if $ensure == 'directory' {
-    file { "${patterndb::pdb_dir}/${parser}/${name}":
+    file { "${patterndb::config_dir}/${parser}/${name}":
       ensure       => $ensure,
       recurse      => $recurse,
       mode         => '0644',
@@ -31,7 +31,7 @@
       notify       => Exec["patterndb::merge::${parser}"],
     }
   } else {
-    file { "${patterndb::pdb_dir}/${parser}/${name}.pdb":
+    file { "${patterndb::config_dir}/${parser}/${name}.pdb":
       ensure => $ensure,
       mode   => '0644',
       source => $source,

manifests/simple/ruleset.pp

@@ -25,7 +25,7 @@
     }
   }
 
-  $pdb_file = "${patterndb::pdb_dir}/${parser}/${order}${name}.pdb"
+  $pdb_file = "${patterndb::config_dir}/${parser}/${order}${name}.pdb"
 
   concat { "patterndb_simple_ruleset-${title}":
     path   => $pdb_file,

spec/defines/raw_ruleset_spec.rb

@@ -31,9 +31,12 @@
           }
         end
 
-        it {
-          is_expected.to contain_file('BASEDIR/etc/syslog-ng/patterndb.d/default/myrawruleset.pdb')
-        }
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it { is_expected.to contain_file('BASEDIR/usr/local/etc/patterndb.d/default/myrawruleset.pdb') }
+        else
+          it { is_expected.to contain_file('BASEDIR/etc/syslog-ng/patterndb.d/default/myrawruleset.pdb') }
+        end
       end
 
       context 'Raw rulesets with directory' do
@@ -44,11 +47,12 @@
           }
         end
 
-        it {
-          is_expected.to contain_file('BASEDIR/etc/syslog-ng/patterndb.d/default/myrawruleset').with(
-            ensure: 'directory'
-          )
-        }
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it { is_expected.to contain_file('BASEDIR/usr/local/etc/patterndb.d/default/myrawruleset').with(ensure: 'directory') }
+        else
+          it { is_expected.to contain_file('BASEDIR/etc/syslog-ng/patterndb.d/default/myrawruleset').with(ensure: 'directory') }
+        end
       end
     end
   end

spec/defines/simple_rule_spec.rb

@@ -74,10 +74,21 @@
           )
         }
 
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it {
+            is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with(
+              path: '/BASEDIR/usr/local/etc/patterndb.d/default/myruleset.pdb'
+            )
+          }
+        else
+          it {
+            is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with(
+              path: '/BASEDIR/etc/syslog-ng/patterndb.d/default/myruleset.pdb'
+            )
+          }
+        end
         it {
-          is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with(
-            path: '/BASEDIR/etc/syslog-ng/patterndb.d/default/myruleset.pdb'
-          )
           is_expected.to contain_concat__fragment('patterndb_simple_rule-myrule-header').with(
             target: 'patterndb_simple_ruleset-myruleset'
           ).with_content(

spec/defines/simple_ruleset_spec.rb

@@ -59,8 +59,13 @@
 
         it { is_expected.to contain_patterndb__parser('default') }
 
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/usr/local/etc/patterndb.d/default/myruleset.pdb') }
+        else
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/default/myruleset.pdb') }
+        end
         it {
-          is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/default/myruleset.pdb')
           is_expected.to contain_concat__fragment('patterndb_simple_ruleset-myruleset-header').with_content(
             %r{<patterns>.*<pattern>P1</pattern>.*</patterns>}m
           )
@@ -79,8 +84,13 @@
 
         it { is_expected.to contain_patterndb__parser('default') }
 
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/usr/local/etc/patterndb.d/default/myruleset.pdb') }
+        else
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/default/myruleset.pdb') }
+        end
         it {
-          is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/default/myruleset.pdb')
           is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').that_notifies(
             'Exec[patterndb::merge::default]'
           )
@@ -135,7 +145,13 @@
 
         it { is_expected.not_to contain_patterndb__parser('default') }
         it { is_expected.to contain_patterndb__parser('PARSER') }
-        it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/PARSER/myruleset.pdb') }
+
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/usr/local/etc/patterndb.d/PARSER/myruleset.pdb') }
+        else
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/PARSER/myruleset.pdb') }
+        end
 
         it {
           is_expected.to contain_concat__fragment('patterndb_simple_ruleset-myruleset-header').with(
@@ -304,8 +320,13 @@
 
         it { is_expected.to contain_patterndb__parser('default') }
 
+        case facts[:osfamily]
+        when 'FreeBSD'
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/usr/local/etc/patterndb.d/default/123myruleset.pdb') }
+        else
+          it { is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/default/123myruleset.pdb') }
+        end
         it {
-          is_expected.to contain_concat('patterndb_simple_ruleset-myruleset').with('path' => '/BASEDIR/etc/syslog-ng/patterndb.d/default/123myruleset.pdb')
           is_expected.to contain_concat__fragment('patterndb_simple_ruleset-myruleset-header').with_content(
             %r{<patterns>.*<pattern>P1</pattern>.*</patterns>}m
           )