Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deprecated stdlib functions): replace with validate_legacy equivalents #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(deprecated stdlib functions): replace with validate_legacy equivalents #67

wants to merge 1 commit into from

Conversation

jstewart612
Copy link

No description provided.

@jstewart612 jstewart612 mentioned this pull request Mar 15, 2024
Open
theevilapplepie
theevilapplepie reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@theevilapplepie theevilapplepie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure how backward compatibile we're looking to be here as in if we want to do function availability testing. A lot of repos around github updated in 2017ish so I'm thinking limited concerns. I'm thinking we move forward with it. Thoughts?

@isbear
Copy link

isbear commented Jun 4, 2024 •
edited
Loading

Heyo. Can we get this merged? (Or just use param types, as it is already for $config_file and $config_dir, I can do merge request for that if it is desirable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theevilapplepie theevilapplepie theevilapplepie left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstewart612 @isbear @theevilapplepie