do not rely on systemd for Debian-related families #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian, systemd is not mandatory, so people could still use SysV init scripts. Moreover, the "service" commands handle both cases. On Ubuntu, systemd is mandatory since 16.04. However, the integration with SysV still exist and the conserver package is unmodified compared to Debian and only ships a SysV init script. Moreover, the override was done in /usr/lib/systemd/system, a directory not existing on most Debian systems. Instead, we keep acting like everyone was using SysV init and let the appropriate compatibility bits in the distribution handle the differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian, systemd is not mandatory, so people could still use SysV
init scripts. Moreover, the "service" commands handle both cases. On
Ubuntu, systemd is mandatory since 16.04. However, the integration
with SysV still exist and the conserver package is unmodified compared
to Debian and only ships a SysV init script.
Moreover, the override was done in /usr/lib/systemd/system, a
directory not existing on most Debian systems.
Instead, we keep acting like everyone was using SysV init and let the
appropriate compatibility bits in the distribution handle the
differences.
Fix #6.
Wait for acceptances test to run, I did not run them. Also, I do not use this branch myself as I am running a too old version of Puppet, but I tested the same change on an older version with Ubuntu 12.04, 16.04 and 18.04. Debian packaging is unmodified between Ubuntu and Debian.