Removed support for incredibly dead and buried versions of PHP. #73
Conversation
Only support PHP 5.6 and later.
| @@ -14,7 +14,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.0.0" | |||
| "php": ">=5.6" | |||
There was a problem hiding this comment.
Is it proper to support php-5.6 version at least?
The php-5.6 and php-7.0 are unmaintained on official PHP team.
And the php-7.0 has been release for about three years.
If we want to keep the package e compatibility, I think we can let the package require php-7.0 version at least.
There was a problem hiding this comment.
See? I debated that, too...
I figured if it was going from, literally, 5.0.0, maybe it'll be too much of a shock to active users, especially on legacy sites?
There was a problem hiding this comment.
OK but. I just started thinking... since this will be in effect a new project, I officially hard forked it to phpexpertsinc/chromephp and will be releasing a new composer package. It will definitely target PHP 7.0.
There was a problem hiding this comment.
Maybe we can release two versions.
One is about supporting PHP 5.6.
Another one is about supporting PHP 7.1+.
This can be compatible with PHP 5 users.
There was a problem hiding this comment.
That's right.
I think releasing the new version is the proper way because original package has been inactive for about long time.
|
Everythign in this PR is in PR #74. |
Only support PHP 5.6 and later.
This change is