Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split numbers #59

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Split numbers #59

merged 3 commits into from
Aug 18, 2024

Conversation

cabo
Copy link
Collaborator

@cabo cabo commented Aug 17, 2024

(Via Joe Hildebrand)

@cabo cabo requested a review from hildjj August 17, 2024 12:55
@hildjj
Copy link

hildjj commented Aug 17, 2024

I don't think this is terribly necessary if we believe the tools to handle all of those formats in one pass are readily available. If we are going to make the change, I suggest that the hexfloat bits might want to be a separate rule also, since those are likely to need completely separate processing from the hexints.

@cabo
Copy link
Collaborator Author

cabo commented Aug 17, 2024

In the case of my implementation, I now have very simple, if somewhat repetitive (on the level of a few tokens), code.
It now seems really hard to get this wrong...

@cabo
Copy link
Collaborator Author

cabo commented Aug 17, 2024

(There is indeed a trade-off between making the ABNF best for explaining the syntax and making it most useful as a ready-cut code base for implementers.
I think in this case we have eat the cake and have it, too.)

@hildjj
Copy link

hildjj commented Aug 17, 2024

I think how you have it here is much easier to read. WFM, thanks.

@cabo cabo merged commit d5ae0fa into main Aug 18, 2024
2 checks passed
cabo added a commit that referenced this pull request Aug 21, 2024
Reflect the ABNF changes in #59 in the associated descriptive text.
hildjj added a commit to hildjj/edn-literal that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants